HBASE-24110 Updated Apache POM to version 23#64
Conversation
petersomogyi
left a comment
There was a problem hiding this comment.
In ASF 23 some plugins changed version that we define. It might be a good time to remove those versions and rely on the ASF versions OR there is no specific need to upgrade to the newest version in my opinion.
What I found is different:
apache-rat-plugin: 0.11 - 0.13
maven-compiler-plugin: 3.6.1 - 3.8.1
Probably we don't want to downgrade:
maven-shade-plugin: 3.2.1 - 3.1.1
maven-enforcer-plugin: 3.0.0-M2 - 1.4.1
|
Updating both plugins shouldn't be a problem. I ran them locally and had no problems. I noticed the different versions we use for the shade- and enforcer-plugin compared to the parent pom. As we define them in our |
Correct. Since we define the version in the pluginManagement the one defined in our pom will take precedence. My local checkout was outdated with apache-rat-plugin and maven-compiler-plugin still having defined versions. |
No description provided.